phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Touch areas do not match spec #72

Closed arouinfar closed 9 years ago

arouinfar commented 9 years ago

There are a few issues with the touch areas in dev.3.

dev.3 (left) and Mockup (right): image image

dev.3 (left) and Mockup (right): image image

image

ChandrashekarBemagoni commented 9 years ago

Fixed in above commits. Assigning to @arouinfar for verification

arouinfar commented 9 years ago

The first and third issues appear to have been addressed; however, I'm still unable to retrieve the Wave Detector (Time) and Intensity tools if I click anywhere other than the tool body or probes.

The boxes representing the touch areas have been appropriately updated, but it does not appear that the touch areas themselves have actually been changed. When testing on an iPad, the tools do not expand if I touch the wires in the middle. The same issue exists on a computer. For example, if I hover over the middle of the tools, the cursor remains an arrow and I cannot retrieve the tool: image

I should be able to click ANYWHERE on the tool-- including the wires-- to retrieve it (as in the Java sim). I should also be able to touch anywhere within the box to retrieve the tools. image

Reassigning to @ChandrashekarBemagoni.

ChandrashekarBemagoni commented 9 years ago

Fixed in above commit. Assigning to @arouinfar for verification

arouinfar commented 9 years ago

Thanks! Looks good, so closing.