search

phetsims / blackbody-spectrum

"Blackbody Spectrum" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Short strings should not be centered #102

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/348 This was mentioned in Slack, but I realized there was no issue created for it.

The short strings in the tool box are meant to be towards the left, but they are towards the center. The check boxes should not move from their position in the untranslated sim. To see this, use stringTest=X

shouldcenter

DianaTavares commented 5 years ago

Yes, the check boxes shouldn't move. They should be aligned to the left . Thanks for the observation Katie

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/350 actually

arnabp commented 5 years ago

Text boxes are now aligned to the left. I also had to play around with the alignment and sizes of the other elements in this control panel because of this change. Leaving open for QA, please verify that the entire control panel behaves as expected.

KatieWoe commented 5 years ago

Looks good 1.0.0-rc.3

arnabp commented 5 years ago

Reopening for testing purposes since this is directly correlated with #106 and should be spot checked for the maintenance release.

KatieWoe commented 5 years ago

Looks good in 1.0.1-rc.2