search

phetsims / blackbody-spectrum

"Blackbody Spectrum" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Make the gray saved lines 1pt thinner #103

Closed DianaTavares closed 5 years ago

DianaTavares commented 5 years ago

Amy did interviews today with the Blackbody sim, and she noticed that it is not evident that the red curve is behind the gray curve when the "Save" button is clicked. She suggests making the gray line 1 pt thinner.

I think is ok! What do you think @ariel-phet ?

arnabp commented 5 years ago

Here is the difference for reference: Before

Screen Shot 2019-06-20 at 2 48 25 PM

After

Screen Shot 2019-06-20 at 2 48 07 PM

And how the saved line looks when not overlapped: Before

Screen Shot 2019-06-20 at 2 50 30 PM

After

Screen Shot 2019-06-20 at 2 50 56 PM
DianaTavares commented 5 years ago

I like how it looks when the gray graph is over the red one. But I like it more when both have the same side when they are part.

arnabp commented 5 years ago

Agreed. Since the red line switches being being on top of the saved lines when it's moved, what I could do is restore the size of the saved line when that change happens. That way when a saved line is created it appears smaller and therefore more visible, but once interaction begins it becomes as visible as the red line.

DianaTavares commented 5 years ago

I like it! If it is not a lot of work, I said do it!

ariel-phet commented 5 years ago

Sounds good

arnabp commented 5 years ago

Line widths now change when certain interactions occur to match the requested behavior. Leaving this open for QA testing to verify that these behaviors have been met and no other issues appear with the saved lines and the layout order because of this.

KatieWoe commented 5 years ago

Looks good to me 1.0.0-rc.3