Closed jbphet closed 3 years ago
I've committed changes for these two things. I believe that release branches are currently considered "locked down" based on what @jonathanolson said [in this comment]](https://github.com/phetsims/states-of-matter/issues/354#issuecomment-847194427), so I'll work with him on how to get these changes into a maintenance release.
@jonathanolson - How do I go about getting the two changes listed above into a maintenance release and when is it likely to go out?
Is it a possibility for me to just roll those patches into the latest release branch and have them tested? I just put out RCs for maintenance (so we could also wait until that's fully handled).
@jonathanolson - Yes, absolutely, you can roll these changes into the release branch and incorporate them into the next RC. Please let me know when you do and I'll double check them, but I think they are pretty straightforward.
Rolled into the maintenance release, cherry-picked above (needed manual changes for everything, please verify), and deployed an RC at https://phet-dev.colorado.edu/html/blackbody-spectrum/1.0.8-rc.3/phet/blackbody-spectrum_all_phet.html for testing.
Let me know if this looks ok?
Question: this is the English Blackbody sim. How would I see the effects on the Arabic translation?
On Wed, Jun 9, 2021 at 10:02 PM Jonathan Olson @.***> wrote:
Let me know if this looks ok?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phetsims/blackbody-spectrum/issues/124#issuecomment-858277527, or unsubscribe https://github.com/notifications/unsubscribe-auth/APO5ENJFBJCY2CCGLM5PM5TTSA2MHANCNFSM45N5ON3A .
This was checked in https://github.com/phetsims/QA/issues/656. Looks ok with both ?stringTest=rtl
and ?stringTest=long
@issamali67 - You can't see the full effect on the Arabic translation from the RC version, but you can see how a single string would look in place of all strings. You and I did this when we met over Zoom and made adjustments. To do it, you use the query parameter stringTest=XX
where the XX is whatever string you'd like to test. Here is a screenshot of the sim with stringTest=مخضر
(which Google said was Arabic for "green"):
@jonathanolson - Yes, version 1.0.8-rc.3 looks good with respect to this issue, please feel free to move forward with publication.
Sounds good, I'll be tracking it and will comment here once it's pushed out!
I submitted the Arabic translation for Blackbody Spectrum sim.
On Fri, Jun 11, 2021 at 3:19 PM Jonathan Olson @.***> wrote:
Sounds good, I'll be tracking it and will comment here once it's pushed out!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phetsims/blackbody-spectrum/issues/124#issuecomment-859916099, or unsubscribe https://github.com/notifications/unsubscribe-auth/APO5ENPCSGUT5YB6FH36XULTSJ4VBANCNFSM45N5ON3A .
Closing, handled in maintenance release deployment.
@issamali67 has been working on translating this sim into Arabic, and ran into a few issues. He and I just met over Zoom and tried some modifications to his strings and were able to solve some of the problems that way, but there are two more changes that would help. They are: