quick code review

[pixelzoom]

This sim is being considered for a student project. I'll do a "quick" (not formal or complete) code review to evaluate the state of this sim, then report back to @ariel-phet.

[pixelzoom]

This sim is in good shape. I did a minor amount of cleanup in the above commits, and created 1 related issue (#17).

This is a relatively small sim (10 files, ~1300 lines of code), and it looks feature complete (or close to it). Unless there are significant additional features to add, there's not much in the way of interesting development here. It looks to me like it's close to being done, and just needs someone to polish it off. Something to keep in mind when deciding whether this sim is appropriate for a student project...

Back to @ariel-phet to review results of code review.

[ariel-phet]

@pixelzoom thanks. Seems more like a good starting project for a new internal intern. Clean this up, and get it published.

[pixelzoom]

1/25/18 dev meeting:

@ariel-phet said that most of the work to be done is cosmetic and pixel polishing. @pixelzoom said that there is some additional code cleanup that would be worthwhile. @jbphet asked me to add notes about anything else that I recommend cleaning up in the code.

[pixelzoom]

@jbphet asked me to add notes about anything else that I recommend cleaning up in the code.

@jbphet I recommend cleaning up #17, #18, #19 before turning this over to an intern.

[jbphet]

One of the three issues listed in the comment above has been addressed, but the other two have not been. Work on this sim is on hold for a while, so I'm unassigning until work resumes.

[arnabp]

Supplanted by primary code review: https://github.com/phetsims/blackbody-spectrum/issues/33