phetsims / blackbody-spectrum

"Blackbody Spectrum" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Where to put intensity label when curve moves off screen #25

Closed arnabp closed 6 years ago

arnabp commented 6 years ago

In the latest dev build I've run into some trouble with where to put the text label when the curve becomes too large or too small.

The current implementation has the text stop when it hits the right border of the graph (when temperature becomes too small, or graph is zoomed in to the left of the peak). It also stops just above the tick marks while moving down (when temperature becomes too small). Some other options might be to allow the text to move past the bounds of the graph, or have it continue to move but allow the text to disappear as it moves past the border of the graph.

For higher temperatures, when the text gets too high it will continue to rise past the border of the graph, then the border of the sim. Options here include having it stop at the upper border of the sim, or the upper border of the graph (or leaving it as is).

DianaTavares commented 6 years ago

In my opinion:

I like the actual behavior that you create: when the curve get smaller, the user can still read the text and it move to the peak position to the corner of the graph, but I think that may be good idea to add a little arrow close to the number when the peak is out of the graph values, because I think that give an idea to the user of use the zooms elements to see the peak position. screen shot 2018-04-13 at 3 19 05 pm

I suggest the same action when the curve get bigger, the number move with the curve up, but when the curve is much bigger, the number still in the graph, in that way the user can read the vale and a little arrow too, that indicate that the peak is taller.

screen shot 2018-04-13 at 3 29 31 pm

I don't think is good to get the numbers over the vertical axe. It's better to stop the label just before the numbers touch the axe.

screen shot 2018-04-13 at 3 23 48 pm

What do you think @ariel-phet ?

ariel-phet commented 6 years ago

Seems like this would be good to discuss at design meeting. I will talk with @DianaTavares for some various ideas

DianaTavares commented 6 years ago

Talking with @ariel-phet , the decision is to show the value of the Intensity in a box in the top of the graph, in this way the label with the intensity value don't move. The label appears only when the checkbox is selected. This is the mockup: screen shot 2018-05-16 at 5 22 41 pm

DianaTavares commented 6 years ago

Already implemented and looks amazing! closing