search

phetsims / blackbody-spectrum

"Blackbody Spectrum" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Logging in GraphValuesPointNode #42

Closed phet-steele closed 5 years ago

phet-steele commented 5 years ago

There is a console.log statement left at https://github.com/phetsims/blackbody-spectrum/blob/master/js/blackbody-spectrum/view/GraphValuesPointNode.js#L184. These are generally removed in dev testing, and definitely removed by the time we get to rc.

For phetsims/QA/issues/215.

arnabp commented 5 years ago

Ahh, missed one. I'm surprised grunt lint doesn't catch these, should it? Or is that outside the scope of what lint is for?

phet-steele commented 5 years ago

@arnabp my guess is probably that lint does not check these. They aren't always bad to have, only in QA tested versions. I don't think lint can distinguish between a QA tested build and any other build, if that makes sense at all. In other words, there are likely scenarios where logging is desirable.

arnabp commented 5 years ago

Makes sense. Thanks for the catch, closing.