search

phetsims / blackbody-spectrum

"Blackbody Spectrum" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Active and saved lines should have similar behavior to Graphing Quadratics #60

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/215 In the sim at the moment, the red line is layered behind any saved lines, meaning that as it moves it can hide behind existing lines. Compare this to graphing quadratics, which starts with the saved line in front and that saved line moves back when adjustments are made to the red line.

DianaTavares commented 5 years ago

I review graphic quadratics and I like that effect where the saver line (the gray one) has the border color of the moving graph (black one)when bout are overlapped.

screen shot 2018-11-07 at 3 09 47 pm

this is the way that may look with Blackbody

screen shot 2018-11-07 at 3 17 02 pm

And I am agree that the interactive line should be over the saved graphs.

What do you think @ariel-phet ?

ariel-phet commented 5 years ago

@DianaTavares I agree, that is a nice solution in graphing quadratics that we should apply hear as well

arnabp commented 5 years ago

The saved line is now smaller than the main line, creating an outline effect when it's saved and increasing visibility of both lines when overlapped, closing.

KatieWoe commented 5 years ago

This behavior isn't exactly what was meant. In Graphing Quadratics the active line is only behind the saved lines until some sort of interaction occurs. After interaction occurs the active line is layered at the front. This can be seen in the first screen, which is more comparable in behavior to this sim, but easier to demonstrate on the second screen, as shown bellow. I believe this is what was meant above. In https://github.com/phetsims/QA/issues/285 the active line is permanently behind the saved line. Up to @DianaTavares and @ariel-phet if they want it changed. If not, feel free to close. howgqdoesit

DianaTavares commented 5 years ago

I really like that the active line stay in from of the saved lines. I am agree with @KatieWoe that implemente the same behavior that graphing quadratics is nicer. What do you think @ariel-phet?

ariel-phet commented 5 years ago

@DianaTavares I agree, the behavior should match graphing quadratics.

arnabp commented 5 years ago

The saved graph now appears in front of the main graph whenever it's created, then moves behind the main graph as soon as the main graph changes in any way. This should match with the graphing quadratics behavior.