search

phetsims / blackbody-spectrum

"Blackbody Spectrum" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Small design pass on y axis labels, scientific notation, and number resizing #71

Closed arnabp closed 5 years ago

arnabp commented 5 years ago

@ariel-phet @DianaTavares I've done a number of changes involving the graph point label and y-axis max label as per #62. I made a lot of discretionary tweaks to when a label resizes, and how much it resizes by, when switching in and out of scientific notation. Can you play around with it a bit and see if it looks right? Do any of the sizes seem off?

Blackbody Spectrum 1.0.0-dev.13

DianaTavares commented 5 years ago

Nice Work @arnabp!! I really like it!

one of the things is that in scientific notation the labels of the dot is bigger that the y-axis max label, and not with regular numbers.

screen shot 2019-02-12 at 3 26 28 pm screen shot 2019-02-12 at 3 22 16 pm

I remember that one of the agreement about the thermometer was to change the temperature in 50 K, but I don't find that written in any issue. But in the way that is in this moment, that the temperature can be change in small steps, strange thing can be observe, like a dot label a little bigger that the max y-axe label

screen shot 2019-02-12 at 3 17 42 pm

Or that several temperatures has the same Spectral radiance, for example from 1544K to 1603K .

screen shot 2019-02-12 at 3 35 00 pm screen shot 2019-02-12 at 3 35 31 pm

In the beginning I thought that the scientific notation was bigger in text size that the decimal numbers, but not, they are the same:

screen shot 2019-02-12 at 3 41 55 pm

Is possible to move the "X" closer to the numbers? (to have the same separation like the one between the 1 and the 0)

what do you think @ariel-phet ?

ariel-phet commented 5 years ago

@arnabp most things look pretty good to me, but there appears to be some unecessary space when the y-axis label changes to scientific notation between the "power of 10" and the multiplication symbol.

Notice in the screenshot below that the Graph Value scientific notation looks appropriately spaced but the y-axis label is a bit oddly spaced.

scientific notation

Found while looking at https://github.com/phetsims/QA/issues/328

arnabp commented 5 years ago

Good catch. I've updated the spacing on the y-axis label to be consistent with the graph point label. Looks like that's the last comment on this design pass so I'll go ahead and close this.