search

phetsims / blackbody-spectrum

"Blackbody Spectrum" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

"K" should be translatable #74

Closed chrisklus closed 5 years ago

chrisklus commented 5 years ago

From https://github.com/phetsims/blackbody-spectrum/issues/33.

In States of Matter, "K" is translatable, so it should be here as well. All other strings look good.

screen shot 2019-02-15 at 3 46 04 pm
arnabp commented 5 years ago

Added the appropriate string, used the same label name as was used in States of Matter, closing.

chrisklus commented 5 years ago

The usage of kelvinUnitsString looks good in BlackbodySpectrumScreenView.js, but 'K' is still hard-coded in SavedGraphInformationPanel.js - could you use it there as well?

Screen Shot 2019-06-25 at 5 27 42 PM
arnabp commented 5 years ago

Appropriate changes made, leaving open for QA

KatieWoe commented 5 years ago

Now that the saved line Ks are translatable, the box can become too large. There should be a max width. toolong https://github.com/phetsims/QA/issues/357

arnabp commented 5 years ago

Added the maxWidth, should be good now, closing.