search

phetsims / blackbody-spectrum

"Blackbody Spectrum" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Zooming axis relayers active line #90

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Test device: Dell Operating System: Win 10 Browser: Chrome Problem description: For https://github.com/phetsims/QA/issues/320. Related to https://github.com/phetsims/blackbody-spectrum/issues/60 When the graph axes are zoomed in or out, the red active line is moved behind the grey solid line, even when it was moved and brought to the front before. Steps to reproduce:

  1. Save at least one line
  2. Move the thermometer to bring the red line to the front. Make sure lines still overlap some
  3. Zoom in the x-axis (or y-axis)
  4. Observe the two lines
  5. Move the thermometer again and observe

Screenshots: zoomrelayers

Troubleshooting information (do not edit):

Name: ‪Blackbody Spectrum‬ URL: https://phet-dev.colorado.edu/html/blackbody-spectrum/1.0.0-dev.16/phet/blackbody-spectrum_en_phet.html Version: 1.0.0-dev.16 2019-05-21 21:44:52 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.157 Safari/537.36 Language: en-US Window: 1536x722 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
DianaTavares commented 5 years ago

good catch @KatieWoe. Yes, it look strange, it need to be fixed.

arnabp commented 5 years ago

Changes to layering of active and saved lines should now match up with expected behavior, closing