Closed KatieWoe closed 5 years ago
This is related to #71. The intent was never to make the arrow completely disappear, I did want it to be somewhat visible if it, say, barely clipped the label. But the arrow at the very bottom of the axis is pretty ugly. So I'll reduce the size of the arrows so they fit. However, it'll still be clip a little when it's lined up horizontally and the clipping will be more apparent at the top. See master (phettest) and let me know how it looks @DianaTavares
can the background of the label be bigger to get closer to the white vertical line of the y_axe?
I think that it look good, but if you extend a little the background of the label to cover the arrow, it looks like only belongs to the graph and not outside.
Arrow clipping now lines up perfectly with the leftmost side of the y axis, this should make the most sense without having any stray pixels visually, closing.
Looking at https://github.com/phetsims/QA/issues/328. I saw that the point gets a little cut off now if close to the edge. I think this looks better than the alternative, so feel free to close if you agree @DianaTavares
can the dot just be in front of the label black background?
Was able to split up the dot and the arrows and put the arrows in front of the text label. I'll keep this open for testing.
Looks good 1.0.0-rc.2
Should this be examined @DianaTavares?
Do you mean that a tiny section fo the arrow still visible? I remember that @arnabp said that it is not a way to tell the arrow to disappears when it is outside the graph. For that reason, we put the background color to the value's label to cover the arrow. If we do that background bigger, it is going to cover part of the zero. Then I think that is ok the way it is now.
Ok. Thanks for the clarification.
Test device: Dell Operating System: Win 10 Browser: Firefox Problem description: For https://github.com/phetsims/QA/issues/320. Fairly minor When the graph value arrows go over the y-axis, the left disappears so it doesn't cover a number. However, in certain locations (mostly near the bottom of the graph) parts of it can still be seen. Steps to reproduce:
Screenshots:![arrowcorners](https://user-images.githubusercontent.com/41024075/58197874-65fe3380-7c8a-11e9-9df3-dbc1255f8b94.gif)
Troubleshooting information (do not edit):