search

phetsims / blackbody-spectrum

"Blackbody Spectrum" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Colors of the star should match the Flash version #99

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/328. @DianaTavares and I noticed that the html colors are darker than the flash colors. It caught my attention in the area that is around the light bulb temperature. It looks particularly brown to me, which seemed odd. Creating this issue for discussion of what the colors should look like.

DianaTavares commented 5 years ago

The colors in the flash and in the HTML5 version are different (I think that the HTML5 version have a dark background behind the star). For example this pictures with the same temperature in both sims: Flash Screen Shot 2019-06-11 at 3 48 56 PM

HTML5 Screen Shot 2019-06-11 at 2 41 02 PM

Both color together: Screen Shot 2019-06-11 at 3 51 10 PM

looking for references in internet about the color of stars according with the temperature, most of them are very similar to this:

Screen Shot 2019-06-11 at 3 08 18 PM

with orange and red for the lower temperatures. In the Flash we can get orange and red, but in the HTML5, they look like brown.

My suggestion is to use the same colors that the Flash version that is more similar to the references in other websites.

ariel-phet commented 5 years ago

@arnabp yes this should be fixed, feel free to use the flash sim as a reference. My guess is that as @DianaTavares pointed out there is something going on with an interaction between the star, its color opacity, and the background. You might need to layer in something on the background of the star, or perhaps they colors just need to be at full opacity.

arnabp commented 5 years ago

Yep, I've changed the opacity of the star to be more forgiving at the mid-range of the thermometer. All the colors are closer to what they should be now, and opacity decreases occur more aggressively under light bulb temperature now.