Open samreid opened 9 years ago
Here's Brand.js for the 'adapted-from-phet' brand:
define( function() {
'use strict';
return {
id: 'adapted-from-phet',
name: null, // {string} For example: 'My Company'
copyright: null, // {string} For example: 'Copyright © 2014, My Company'
links: null // {Object[]} For example: { text: 'My Company Support', url: 'https://www.mycompany.com/support' }
};
} );
Does PhET want name
, copyright
and/or links
fields filled in? If so, with what?
Also... If PhET fills in its name, copyright, and links, then is it anticipated that a 3rd-party can change that information and still have it be an 'adapted-from-phet' brand?
I was going to move 'adapted-from-phet' to 'master', but I'm holding off until the above questions are answered.
Leaving these as null means the about dialog will show no company, copyright statement or links, which I think is appropriate. (Not sure what you were thinking may make sense here). The one exception I can think of is whether we want to have an "adapted from PhET" link, where PhET links back to our homepage and people could take it out if the wanted to.
Here's an About dialog and navbar for the 'phet' brand:
And for the 'adapted-from-phet' brand:
Keeping in mind that this will now be the default brand, which people will be publishing if they take PhET code and don't make a brand of their own, or don't modify the 'adapted-from-phet' brand ...
• Is it OK that 'PhET Interactive Simulations' and PhET's copyright are not shown in the About dialog?
• Is it OK that there is no link to any licensing or terms?
• Why are we showing credits without any indication that they are PhET people? If someone fills in a company name, it's going to look like the credited people work for that company.
• Are we going to show a "Translation Credits" link? See phetsims/joist#163.
• Should the "adapted from PhET" menu have an item for accessing the PhET website? (It currently does not.)
• etc.
Again... I think this brand is currently half-baked, and I don't think we've considered the implications of what we are and are not showing.
Assigning to @ariel-phet for comment.
Btw... This issue:
• Why are we showing credits without any indication that they are PhET people? If someone fills in a company name, it's going to look like the credited people work for that company.
... is an issue with all brands. There is no brand-specific logic for adding credits, they are added regardless of brand.
@pixelzoom - my inclination would be to remove pretty much everything except the sim name and the version, as well as say something like "Adapted from the PhET sim Hooke's Law"
We really do not know how people are going to use the adapted from brand even if we put clear instructions. I am guessing a common use case is going to be hard coded translations (which we have already seen), but since the third party is building a version that we cannot guarantee is stable, etc. I am not sure we want any of our names on it.
This seems like a good discussion to be had with @kathy-phet, I will get it on her radar.
Renamed this issue.
Decisions to be made: • logos • About dialog contents • PhET menu items
JB (Requires KP): What should the default brand be for someone that just checks out our sim? Right now it is blank. SR: An alternative would be “adapted from PhET” Everyone agreed “adapted from PhET” would be a good new default Revisit the README.md in https://github.com/phetsims/brand Maybe put a note that PhET is trademarked and can only be used with the expressed written consent. Put a comment in the phet brand that this is “hands off” federal trademarked one.