search

phetsims / brand

Assets and metadata for web apps built with phetsims/joist and related libraries.
http://scenerystack.org/
MIT License
1 stars 9 forks source link

make 'adapted-from-phet' the default brand #19

Closed pixelzoom closed 9 years ago

pixelzoom commented 9 years ago

Broke this issue out of https://github.com/phetsims/brand/issues/13.

Until all brands are in master, this means moving the 'adapted-from-phet' branch to master.

samreid commented 9 years ago

@pixelzoom is this complete?

pixelzoom commented 9 years ago

No, hasn't been done. Was potentially waiting until all brands are in master. And doesn't need to be addressed for S2015R.

samreid commented 9 years ago

I'll be working on some other branding issue in the near future, so I'll assign this to me and take a look at it as well.

samreid commented 9 years ago

adapted-from-phet is now the default brand, and can be overriden with a grunt option --brand or a query parameter ?brand

Closing.

pixelzoom commented 9 years ago

Reopening.

Did we bail on being able to specify the brand in $HOME/.phet/build-local.properties ?

samreid commented 9 years ago

We did not bail on being able to specify the brand in $HOME/.phet/build-local.json, it is being tracked and labeled for discussion at the next developer meeting in https://github.com/phetsims/brand/issues/11

Please close if there is nothing else to do for this issue.