Closed KatieWoe closed 4 years ago
build-a-molecule : fuzz : built : run
Query: fuzz&memoryLimit=1000
Uncaught Error: Error creating WebGL context.
Error: Error creating WebGL context.
at new se (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1077:94912)
at new H (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6988676)
at new N (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6992630)
at new C (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6995329)
at i.value (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:7029235)
at Object.fire (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6936873)
at C.setButtonState (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6888044)
at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6887408)
at C.buttonUp (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6882020)
at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6880978)
id: Bayes Chrome
Approximately 12/2/2019, 7:44:27 PM
build-a-molecule : fuzz : built : run
Query: fuzz&memoryLimit=1000
Uncaught TypeError: Cannot read property 'atoms' of null
TypeError: Cannot read property 'atoms' of null
at Function.C.getCombinedMoleculeFromBond (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:935502)
at C.getPossibleMoleculeStructureFromBond (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6759491)
at C.canBond (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6760413)
at https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6759735
at Array.forEach (<anonymous>)
at https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6759650
at Array.forEach (<anonymous>)
at C.attemptToBondMolecule (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6759622)
at C.atomDropped (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:6754576)
at C.end [as _end] (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1079:7031166)
id: Bayes Chrome
Approximately 12/2/2019, 7:44:27 PM
build-a-molecule : fuzz : require.js : run
Query: brand=phet&ea&fuzz&memoryLimit=1000
Uncaught TypeError: Cannot read property 'atoms' of null
TypeError: Cannot read property 'atoms' of null
at Function.MoleculeStructure.getCombinedMoleculeFromBond (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/MoleculeStructure.js?bust=1575348421529:541:10)
at Kit.getPossibleMoleculeStructureFromBond (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575348421529:526:32)
at Kit.canBond (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575348421529:601:95)
at https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575348421529:552:49
at Array.forEach (<anonymous>)
at https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575348421529:542:20
at Array.forEach (<anonymous>)
at Kit.attemptToBondMolecule (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575348421529:539:22)
at Kit.atomDropped (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575348421529:200:16)
at DragListener.end [as _end] (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/BAMView.js?bust=1575348421529:350:24)
id: Bayes Chrome
Approximately 12/2/2019, 7:44:27 PM
build-a-molecule : fuzz : require.js : run
Query: brand=phet&ea&fuzz&memoryLimit=1000
Uncaught Error: Error creating WebGL context.
Error: Error creating WebGL context.
at new WebGLRenderer (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/sherpa/lib/three-r104.js?bust=1575358719173:22839:12)
at new ThreeStage (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/mobius/js/ThreeStage.js?bust=1575358719308:56:28)
at new ThreeNode (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/mobius/js/ThreeNode.js?bust=1575358719308:43:20)
at new Molecule3DDialog (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/view3d/Molecule3DDialog.js?bust=1575358719308:80:26)
at MoleculeCollectingView.showDialog (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/BAMView.js?bust=1575358719308:222:21)
at Object.fire (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/view3d/ShowMolecule3DButtonNode.js?bust=1575358719308:53:9)
at ButtonListener.setButtonState (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/input/ButtonListener.js?bust=1575358719308:111:31)
at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/input/ButtonListener.js?bust=1575358719308:75:14)
at ButtonListener.buttonUp (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/input/DownUpListener.js?bust=1575358719308:135:22)
at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/input/DownUpListener.js?bust=1575358719308:64:16)
id: Bayes Chrome
Approximately 12/2/2019, 7:44:27 PM
build-a-molecule : fuzz : require.js : run
Query: brand=phet&ea&fuzz&memoryLimit=1000
Uncaught Error: Error creating WebGL context.
Error: Error creating WebGL context.
at new WebGLRenderer (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/sherpa/lib/three-r104.js?bust=1575385348617:22839:12)
at new ThreeStage (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/mobius/js/ThreeStage.js?bust=1575385348727:56:28)
at new ThreeNode (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/mobius/js/ThreeNode.js?bust=1575385348727:43:20)
at new Molecule3DDialog (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/view3d/Molecule3DDialog.js?bust=1575385348727:80:26)
at BAMView.showDialog (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/BAMView.js?bust=1575385348727:222:21)
at Object.fire (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/view3d/ShowMolecule3DButtonNode.js?bust=1575385348727:53:9)
at ButtonListener.setButtonState (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/input/ButtonListener.js?bust=1575385348727:111:31)
at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/input/ButtonListener.js?bust=1575385348727:75:14)
at ButtonListener.buttonUp (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/input/DownUpListener.js?bust=1575385348727:135:22)
at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/input/DownUpListener.js?bust=1575385348727:64:16)
id: Bayes Chrome
Approximately 12/2/2019, 7:44:27 PM
build-a-molecule : xss-fuzz : run
Query: brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Uncaught TypeError: Cannot read property 'atoms' of null
TypeError: Cannot read property 'atoms' of null
at Function.MoleculeStructure.getCombinedMoleculeFromBond (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/MoleculeStructure.js?bust=1575353837198:541:10)
at Kit.getPossibleMoleculeStructureFromBond (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575353837198:526:32)
at Kit.canBond (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575353837198:601:95)
at https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575353837198:552:49
at Array.forEach (<anonymous>)
at https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575353837198:542:20
at Array.forEach (<anonymous>)
at Kit.attemptToBondMolecule (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575353837198:539:22)
at Kit.atomDropped (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/model/Kit.js?bust=1575353837198:200:16)
at DragListener.end [as _end] (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/BAMView.js?bust=1575353837198:350:24)
id: Bayes Chrome
Approximately 12/2/2019, 7:44:27 PM
build-a-molecule : xss-fuzz : run
Query: brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Uncaught Error: Assertion failed: attempt made to remove particle that is not in bucket
Error: Assertion failed: attempt made to remove particle that is not in bucket
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/assert/js/assert.js?bust=1575356144939:22:13)
at Bucket.removeParticle (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/phetcommon/js/model/SphereBucket.js?bust=1575356145060:91:17)
at particleRemovedListener (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/phetcommon/js/model/SphereBucket.js?bust=1575356145060:80:14)
at TinyEmitter.emit (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/axon/js/TinyEmitter.js?bust=1575356145060:68:55)
at BooleanProperty._notifyListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/axon/js/Property.js?bust=1575356145060:275:27)
at BooleanProperty.set (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/axon/js/Property.js?bust=1575356145060:176:16)
at BooleanProperty.set value [as value] (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/axon/js/Property.js?bust=1575356145060:345:34)
at DragListener.start [as _start] (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/BAMView.js?bust=1575356145060:277:45)
at https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/listeners/DragListener.js?bust=1575356145060:241:29
at DragListener.onPress (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/listeners/PressListener.js?bust=1575356145060:524:19)
id: Bayes Chrome
Approximately 12/2/2019, 7:44:27 PM
build-a-molecule : xss-fuzz : run
Query: brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Uncaught Error: Assertion failed: reentry detected, value=false, oldValue=true
Error: Assertion failed: reentry detected, value=false, oldValue=true
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/assert/js/assert.js?bust=1575356144939:22:13)
at BooleanProperty._notifyListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/axon/js/Property.js?bust=1575356145060:272:17)
at BooleanProperty.set (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/axon/js/Property.js?bust=1575356145060:176:16)
at BooleanProperty.set value [as value] (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/axon/js/Property.js?bust=1575356145060:345:34)
at DragListener.end [as _end] (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/build-a-molecule/js/view/BAMView.js?bust=1575356145060:318:45)
at https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/listeners/DragListener.js?bust=1575356145060:284:27
at DragListener.onRelease (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/listeners/PressListener.js?bust=1575356145060:551:19)
at Action.execute (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/axon/js/Action.js?bust=1575356145060:230:20)
at DragListener.release (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/listeners/PressListener.js?bust=1575356145060:383:27)
at DragListener.release (https://bayes.colorado.edu/continuous-testing/snapshot-1575341067960/scenery/js/listeners/DragListener.js?bust=1575356145060:280:39)
id: Bayes Chrome
Approximately 12/2/2019, 7:44:27 PM
@Denz1994 this problem has been appearing on CT for a long time, can you please look into it?
This bug is present due to webgl being disabled on certain browsers when creating the 3D molecule representation (more specifically, its ThreeObject). There is no current fallback for rendering the ThreeObject without using webgl. This means we need to check if webgl is enabled and enforce an alternative.
In Density, each screen view is filled with a message regarding webgl compatibility (see image below). This message links to this webpage. @jonathanolson mentioned that maybe we wouldn't want to show a 3d button when webgl is disabled. Or maybe we can show a message in the dialog box.
Thoughts @arouinfar or @ariel-phet?
The sim is still largely usable without the 3D dialog, so I wouldn't want to prevent users from accessing the sim when webgl is disabled. I would be in favor of including the webgl warning in the 3D dialog.
@Denz1994 I agree with @arouinfar - a message in the 3D dialog seems appropriate.
Every time the 3d button is pressed and webgl isn't supported this dialog shows. What do you think about this dev version @arouinfar? Any polishes?
I think you can test this on edge. If not, this link shows how to disable webgl on Firefox and you can test from there.
@Denz1994 the behavior of the dialog is looking good. I wonder if we should add another sentence to explain that the 3D rendering is unavailable. Perhaps something like this:
3D rendering of the molecule requires WebGL.
WebGL is not enabled or not available. Click to learn more.
@ariel-phet what do you think?
@arouinfar I agree - that would be clearer to the user
Thanks @ariel-phet.
@Denz1994 can you adjust the message in the dialog?
The text has been updated. See below @arouinfar.
The screenshot looks good @Denz1994.
Closing this issue. We now have a fallback for the WebGL context.