search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Boron ate the Hydrogen #127

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago

Test device Dell Operating System Win 10 Browser Chrome Problem description For https://github.com/phetsims/QA/issues/459 The image that appears in the answer box for Borane looks like hydrogen is inside the boron rather than around it.

Visuals What it looks like in the sim: isit What it should look like: image

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Build a Molecule‬ URL: https://phet-dev.colorado.edu/html/build-a-molecule/0.0.0-dev.23/phet/build-a-molecule_all_phet.html Version: 0.0.0-dev.23 2019-11-20 23:29:39 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.97 Safari/537.36 Language: en-US Window: 1536x722 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
ghost commented 4 years ago

You are Boron me with these silly issue titles, Katie.

arouinfar commented 4 years ago

Looks like a bug to me @Denz1994

Denz1994 commented 4 years ago

This is fixed for Boron but a more general solution is explained here.

Denz1994 commented 4 years ago

Can you confirm this was fixed in this dev version @KatieWoe?

KatieWoe commented 4 years ago

Looks much better now. This is what the Borane molecule looks like now: nowlookslike

Denz1994 commented 4 years ago

What do you think @arouinfar? A more general solution is described here.

arouinfar commented 4 years ago

@Denz1994 looks good! The appearance is a close match for the Java version.