phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Organic Nomenclature #131

Closed arouinfar closed 4 years ago

arouinfar commented 4 years ago

According to teacher tips, we should be showing the common name for organic molecules, where applicable. However, there are some quirks in the current behavior.

A notable example would be that Acetic Acid Methyl Ester displays a common name, but isopropyl alcohol does not (propan-2-ol).

BAM-nomenclature BAM-nomenclature-3

There some other edge cases like “n-propane” where the “n” doesn’t actually carry any meaningful information about the structure (unlike n-butane vs. isobutane).

BAM-nomenclature-2

We will need to add a few more overrides to the nomenclature, but I should first consult some HS/AP textbooks to see how organic nomenclature is handled.

Denz1994 commented 4 years ago

These names used for the molecules can be adjusted relatively easily. Isopropyl alcohol and propane show the suggested names from above. If there are any other molecules that should be renamed we should detail in this issue.

@arouinfar Can you confirm this looks okay in this dev version. Also what other molecules should be adjusted.

arouinfar commented 4 years ago

Thanks @Denz1994. After playing around quite a bit with the simulation, I couldn't find any other organic molecules that need a nomenclature override.

I would, however, recommend that we use "isopropanol" for the override, since it's more parallel to "methanol" and "ethanol".

Denz1994 commented 4 years ago

Override provided for isopropyl alcohol -> isopropanol. If this looks good then I'll leave for you to close @arouinfar.

image

arouinfar commented 4 years ago

👍