search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

On Chrome OS, buckets too large, spill over into next page of carousel #132

Closed ghost closed 4 years ago

ghost commented 4 years ago

Test Device

Lovelace

Operating System

Chrome OS 79.0.3945.42

Browser

Chrome

Problem Description

For https://github.com/phetsims/QA/issues/459.

Visuals

1 2 3

Denz1994 commented 4 years ago

From https://github.com/phetsims/build-a-molecule/issues/134#issuecomment-572635601

This was caused by the bounds of buckets being leaked over into other pages in the carousel. Adjusting the bounds of the kitPanel and the bucket widths makes it so a user can drag these leaked atoms into another kit's playAreaNode.

This also makes it so they buckets don't visually leak into the next carousel page.

Denz1994 commented 4 years ago

Can @KatieWoe verify this isn't an issue anymore in this dev version?

KatieWoe commented 4 years ago

There is a very, very minor overlap of the buckets in the third page of the carousel on the third screen. So the second and forth pages have slight dots on the edge. Seen on Win 10 Chrome. Super nitpicky. here2 here4

Denz1994 commented 4 years ago

Very good eye @KatieWoe. This is literally a pixel polish. Should be fixed in this dev

KatieWoe commented 4 years ago

This issue looks good on that dev version

KatieWoe commented 4 years ago

I'll also look at a few other platforms just in case today.

KatieWoe commented 4 years ago

All looks good

Denz1994 commented 4 years ago

Thanks for checking. Closing this one.