phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

CT value is not a member of Enumeration [object Object] #136

Closed zepumph closed 4 years ago

zepumph commented 4 years ago

This CT bug is occurring because validation for enumerations currently expects to only ever have one Enumeration for a set of keys. This is up for discussion over in https://github.com/phetsims/phet-core/issues/79 but in the mean time I think this assertion for this sim has an easy solution.

zepumph commented 4 years ago

@Denz1994 please review, do you think this is an alright change?

Denz1994 commented 4 years ago

Minor formatting changes in https://github.com/phetsims/build-a-molecule/commit/825842a3a0708c1951c6ddd30f200ccbecec884b, but I used a similar solution for https://github.com/phetsims/masses-and-springs/issues/349. I haven't seen this pop up on CT either.

Denz1994 commented 4 years ago

CT has been clear for about half a day's worth of cycles. I'm going to close this one.