search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Matt should be present for the next RC deploy #145

Closed mattpen closed 4 years ago

mattpen commented 4 years ago

See https://github.com/phetsims/perennial/issues/146#issuecomment-577354683.

I'd like to be present for the next RC deploy so I can investigate permissions issues on bayes if needed.

Denz1994 commented 4 years ago

Note for self: Make sure that RC deploys don't interfere with https://github.com/phetsims/build-a-molecule/issues/167.

mattpen commented 4 years ago

Note for self: Make sure that RC deploys don't interfere with #167.

RC deploys should be fine. Its just production deploys that could be problematic as there could be some filesystem level conflicts.

chrisklus commented 4 years ago

from 06/18/20 dev meeting:

@mattpen and @Denz1994 will find time to overlap on this

Denz1994 commented 4 years ago

@mattpen @jonathanolson and I created a successful deploy with no issues. Closing this one.

Denz1994 commented 4 years ago

Correction: We did run into problems with build-a-molecule_en.html not committing after being built. @jonathanolson mentioned this was related to https://github.com/phetsims/perennial/issues/172 and the last call to gitIsClean() in updateHTMLVersion.js. This was sorted out after manually committing and pushing this file on Master.