search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

incorrect nomenclature override #149

Closed arouinfar closed 4 years ago

arouinfar commented 4 years ago

Ethenone is the preferred IUPAC name of C2H2O (arranged H2C=C=O), but is also known as ketene.

Currently, the sim is showing ethenone to be this structure: image

This is the correct structure of ethenone, but the nomenclature override is using the less-prefered "ketene". image

@Denz1994 can you look into this? The first structure should not be named at all, and the 2nd should be called "ethenone" not "ketene".

arouinfar commented 4 years ago

Okay, scratch what I said about the preferred name. Looking at pubchem (which is what I should have checked first) the preferred name is indeed "ketene".

@Denz1994 the problem is that this structure is being named, when it isn't actually a molecule that exists, nor is it ethenone/ketene. image

Denz1994 commented 4 years ago

Ethenone was removed from the data set so it can't be created. I'm not sure when this data set was generated (the earliest record I could find was 09/6/13 ), but perhaps at that time, this data set was generated ethenone was listed as a molecule in the PubChem database.

I don't know the standard for how these molecules are named and if they can change over time, but for the time being it has been removed. Does this look good in master @arouinfar?

arouinfar commented 4 years ago

Looks good in master @Denz1994.

H2C=C=O is being named "ketene" which is consistent with the pubchem entry, and C-C-O is no longer being given a name.

This issue has also reminded me that we should include some information about nomenclature in the Teacher Tips, but I've created a separate issue for that.