follow naming convention for Enumerations

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

8 stars 7 forks source link

follow naming convention for Enumerations #166

Closed pixelzoom closed 4 years ago

pixelzoom commented 4 years ago

From https://github.com/phetsims/phet-core/issues/43...

In Direction.js, rename DIRECTION to Direction.

In Molecule3DDialog.js, rename VIEW_STYLE to ViewStyle

jbphet commented 4 years ago

This was assigned to me during today's developer meeting, and I think it was because @pixelzoom thought these were in build-an-atom, but they are actually in build-a-molecule. Assigning to @Denz1994, since he's actively working on BAM.

pixelzoom commented 4 years ago

Oops, sorry for the incorrect repo. Transferring this issue to build-a-molecule.

Denz1994 commented 4 years ago

The casing was corrected for DIRECTION to Direction and VIEW_STYLE to ViewStyle. Closing this one.