search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Pointer area review #177

Closed jonathanolson closed 4 years ago

jonathanolson commented 4 years ago

As noted in the code review doc (https://github.com/phetsims/build-a-molecule/issues/173), there should be a review of pointer areas done and signed off.

Denz1994 commented 4 years ago

Note: Pointer areas are shown for buckets that aren't yet visible but exist in the carousel's preceding and succeeding pages.

Assigning to @arouinfar to sign off on pointer areas.

arouinfar commented 4 years ago

The pointerAreas look sufficiently dilated to me, but I don't have a touch device to test it on. @Denz1994 if this sim has already been tested on an iPad, I think it's safe to assume the touch areas are fine as-is.

Denz1994 commented 4 years ago

This sim has been tested on an iPad and the only issues that came up regarding touch areas were https://github.com/phetsims/build-a-molecule/issues/116. This issue is safe to close.