phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Reset all button does not reset pause button in 3D model view #187

Closed loganbraywork closed 4 years ago

loganbraywork commented 4 years ago

Test device

Windows 10 laptop

Operating System

Windows 10 v. 1903

Browser

Chrome Version 83.0.4103.61

Problem description

For https://github.com/phetsims/QA/issues/506

The reset all button does not unpause the molecule in 3D view, despite the molecule in 3D view being initially unpaused.

Steps to reproduce

  1. Build a molecule
  2. Enter 3D view using the 3D button
  3. Pause the 3D model using the pause button in the pop-up
  4. Reset the sim using the reset all button
  5. Build a molecule
  6. Observe the paused pop-up

Visuals

2020-06-04BldaMlclPause3D

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Build a Molecule‬ URL: https://phet-dev.colorado.edu/html/build-a-molecule/1.0.0-dev.75/phet/build-a-molecule_all_phet.html Version: 1.0.0-dev.75 2020-06-01 13:20:12 UTC Features missing: generatedcontent, csstransforms3d, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36 Language: en-US Window: 1576x776 Pixel Ratio: 1.21875/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4095 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}

Denz1994 commented 4 years ago

This should be fixed in the above commit. I'll release a new dev version to verify.

Denz1994 commented 4 years ago

This dev version can be used for verification.

KatieWoe commented 4 years ago

Confirmed with https://github.com/phetsims/build-a-molecule/issues/191. Same possible issue with molecule orientation.

Denz1994 commented 4 years ago

Sounds good. I'll close this one.