search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Type of 3D model doesn't reset with reset all #191

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago

Test device Dell Operating System Win 10 Browser Chrome Problem description For https://github.com/phetsims/QA/issues/506. When you build a molecule and click the 3D button, there are two options. A ball model and a ball and stick model. The ball model is the default when you launch the sim. If you switch to ball and stick, then use the reset all button the 3D screen will still open in the ball and stick model, rather than the ball mode. Steps to reproduce

  1. Go to the third screen
  2. Build a simple molecule
  3. Go to the 3D view
  4. Switch the model to ball and stick
  5. Exit the view
  6. Build another molecule and look at it in 3D view. Notice that ball and stick model is used.
  7. Press reset all
  8. Build a molecule and open 3D view

Visuals whichtypeofmodel

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Build a Molecule‬ URL: https://phet-dev.colorado.edu/html/build-a-molecule/1.0.0-dev.75/phet/build-a-molecule_all_phet.html Version: 1.0.0-dev.75 2020-06-01 13:20:12 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.97 Safari/537.36 Language: en-US Window: 1536x722 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
KatieWoe commented 4 years ago

Sorry, accidentally posted early. Give me a minute Done

KatieWoe commented 4 years ago

The same goes for the play/pause state of the view.

Denz1994 commented 4 years ago

Play/pause state is addressed in https://github.com/phetsims/build-a-molecule/issues/187 and is awaiting a dev version for verification.

Regarding the view style described above, this should have been fixed in the above commit. The ResetAllButton wasn't resetting the viewStyleProperty. I'll push a dev version to verify this is fixed.

Denz1994 commented 4 years ago

This dev version can be used for verification.

KatieWoe commented 4 years ago

Mostly fixed in that dev version. I think the orientation of the molecule may also be impacted, but that seems like a much smaller issue.

Denz1994 commented 4 years ago

I would vote to pass on the orientation resetting. The initial starting orientation may not show all the molecules based on the camera angle so, in the most general sense, we want the 3D model to be viewed from as many angles as possible.

Not resetting to the original orientation supports the reasoning above, until a specific starting orientation has a purpose in the sim.

Thanks for noting. I'll close this one.