search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Changing Atom Selection Buckets while Built molecule exists causes freeze in IE #192

Closed loganbraywork closed 4 years ago

loganbraywork commented 4 years ago

Test device

Windows 10 Laptop

Operating System

Windows 10 v. 1903

Browser

Internet Explorer v. 11.836.18362.0

Problem description

For https://github.com/phetsims/QA/issues/506

If a molecule is built in the play area and the selection of atom buckets is switched, the built molecule remains in the play area and causes a freeze. The follow console error occurs: SCRIPT438: Object doesn't support property or method 'includes' build-a-molecule_all_phet.html (955,6892033)

Steps to reproduce

  1. Enter any screen
  2. Build a molecule from the atoms available in the atom buckets
  3. Attempt to switch to a different set of atom buckets using the arrow buttons adjacent to the atom buckets

Visuals

2020-06-09BldaMlclIEBroken

Troubleshooting information: !!!!! DO NOT EDIT !!!!!

Name: ‪Build a Molecule‬

URL: https://phet-dev.colorado.edu/html/build-a-molecule/1.0.0-dev.75/phet/build-a-molecule_all_phet.html

Version: 1.0.0-dev.75 2020-06-01 13:20:12 UTC

Features missing: touch, fullscreen

Flags: pointerEnabled, msPointerEnabled, pixelRatioScaling

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; Zoom 3.6.0; rv:11.0) like Gecko

Language: en-US

Window: 1574x773

Pixel Ratio: 1.2200000286102295/1

WebGL: WebGL 0.94

GLSL: WebGL GLSL ES 0.94

Vendor: Microsoft (Internet Explorer)

Vertex: attribs: 16 varying: 15 uniform: 512

Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)

Max viewport: 16384x16384

OES_texture_float: true

Dependencies JSON: {}

Denz1994 commented 4 years ago

It looks like Array.includes() isn't supported by IE. After using _.includes(). things seem to be working fine in IE, but I'll release a dev version for verification.

Denz1994 commented 4 years ago

This dev version can be used for verification.

KatieWoe commented 4 years ago

Looks fixed in that dev version. Noting that we are supporting IE less and less so minor issues with IE may not need to be addressed, although this is a bigger issue.

KatieWoe commented 4 years ago

@Denz1994 not sure if you want these closed, so I'm leaving them to you.

Denz1994 commented 4 years ago

Thanks. Closing.