phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Able to skip levels by re-doing a previous one #194

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago

Test device Dell Operating System Win 10 Browser Chrome Problem description For https://github.com/phetsims/QA/issues/506. It is possible to skip a level by going back to a previous one and redoing it. Once the old level is re completed, the "go to the next level" prompt will come up, and it will create a new level past the uncompleted one. Steps to reproduce

  1. Complete Level one in a game and move to level two
  2. Use the arrow to go back to level one
  3. Use the yellow refresh level to start level one again
  4. Complete level one again and choose to go to the next level.
  5. You are now on level three without having done level two

Visuals skiplevels

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Build a Molecule‬ URL: https://phet-dev.colorado.edu/html/build-a-molecule/1.0.0-dev.75/phet/build-a-molecule_all_phet.html Version: 1.0.0-dev.75 2020-06-01 13:20:12 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.97 Safari/537.36 Language: en-US Window: 1536x722 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
Denz1994 commented 4 years ago

Great catch! The allFilledDialog has been fixed to only show if there isn't a nextCollection present on the currentCollection. This means we should only get the next collection prompt on the last collection (or level).

I'll post a dev version to verify.

Denz1994 commented 4 years ago

This dev version can be used for verification.

KatieWoe commented 4 years ago

Looks good on that dev version

Denz1994 commented 4 years ago

Thanks. Closing.