search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

PropertyStateHandler dependency registration leaks memory #205

Closed zepumph closed 3 years ago

zepumph commented 3 years ago

A memory leak was outlined and fixed in master over in https://github.com/phetsims/axon/issues/328#issuecomment-681042541. It effects PhET brand. Please follow that link to cherry-pick changes into the next maintenance release of this sim.

samreid commented 3 years ago

On hold until https://github.com/phetsims/axon/issues/328#issuecomment-681071910 is cleared up.

Denz1994 commented 3 years ago

Based on @samreid investigation in https://github.com/phetsims/axon/issues/328#issuecomment-681174532 and https://github.com/phetsims/axon/issues/328#issuecomment-681357413 it looks like this sim wasn't affected by a memory leak and a patch isn't essential.

These RC shas also underwent a check for memory leaks in the first RC and no leaks were found. https://github.com/phetsims/QA/issues/509#issuecomment-674233559. This was also after a preceding dev test where there wasn't much time in between test cycles. That dev-test recorded no memory leaks as well.

Closing this issue. If there are any memory leaks found during testing of the next maintenance release, I'll reopen this issue and investigate if the leaks are related to this.