search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Zoom magnification support #208

Open Denz1994 opened 4 years ago

Denz1994 commented 4 years ago

I was testing the zoom magnification feature using the ?supportZoom=true in BAM. The latest BAM RC doesn't work with this query parameter. More specifically, pinch to zoom and Cmd + doesn't work on my MacBook.

Here is the link that was tested.

@ariel-phet mentioned that this shouldn't block 1.0 and most likely will get included in this sim's next maintenance release. Assigning to @jessegreenberg to take an initial look with any assistance I can provide.

jessegreenberg commented 4 years ago

Regarding the query parameter, it looks like SHAs for build-a-molecule were taken while the param was still called zoom (instead of supportsZoom). When zoom is used, there is some magnification but it isn't working very well.

I checked out the scenery SHA for 1.0.0-rc.2, and it is from June 19, 2020. The published molecules-and-light scenery SHA with magnification is from July 21. So it looks like code related to zoom at this release was taken at a transient or not-working state.

Figuring out how to fix the old code could be done, but the scenery SHA for this release is > 2 months old now, and there have been many changes since then related to the zoom feature. It would be much easier (at least for zoom) to include in a republication off of master.

shouldn't block 1.0 and most likely will get included in this sim's next maintenance release.

@Denz1994 will this release be a maintenance release patched into 1.0 or a minor release off of master?

Denz1994 commented 4 years ago

This will most likely be captured in a minor release off of master. We can capture this feature when that time comes.