phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Sim deployed with partial translations #214

Closed Denz1994 closed 4 years ago

Denz1994 commented 4 years ago

It was noted by @oliver-phet that the recently published BAM has a set of translated sims that are partially translated (titles and phet menu). I followed the normal grunt production procedures as documented in https://github.com/phetsims/phet-info/blob/master/deployment-info/chipper-2.0.md but after consulting with @jonathanolson and @jbphet it seems to be that this sim pulled java strings early in its development. The first HTML dev version was in 2013 and as far as our most recent porting efforts, that work started in mid-2019.

Denz1994 commented 4 years ago

@jbphet suggested a motion to remove the translated sims from the website and phet-server, then delete the translated strings in babel. This should give the sim a clean slate. It was also suggested to be careful about removing legit translations that may have been submitted since the last day since the sim went live.

Denz1994 commented 4 years ago

@mattpen and I took a look at the translated sims and determined based on the creation of the translated sims on phet-server no translator submissions were submitted. All the translations were submitted at the same time right when I did the deploy. We went ahead deleted them from phet-server.

Because the en sim page and the translated sim pages are all cached at different levels, tomcat will be delayed in updating the page. What this means is that the partially translated sims will be present on the page for another estimated 24 hours until the cache is refreshed.

Denz1994 commented 4 years ago

I removed the java translated strings from babel. At this point, we are awaiting Tomcat to refresh the webpage, which can take at most 24 hours. I will close this issue when that happens.

Denz1994 commented 4 years ago

The BAM sim page has been updated and the partially translated sims have been removed. Thanks, @mattpen, @jbphet, and @jonathanolson for helping out. Closing this one.