search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

CT Corner overlap on left edge #232

Open KatieWoe opened 1 year ago

KatieWoe commented 1 year ago 
build-a-molecule : xss-fuzz
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1661507973361/build-a-molecule/build-a-molecule_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-molecule%22%2C%22xss-fuzz%22%5D%2C%22snapshotName%22%3A%22snapshot-1661507973361%22%2C%22timestamp%22%3A1661515400877%7D&brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Query: brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Uncaught Error: Assertion failed: Corner overlap on left edge
Error: Assertion failed: Corner overlap on left edge
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1661507973361/assert/js/assert.js:28:13)
at assert (Shape.js:2037:14)
at roundedRectangleWithRadii (RectangularButton.ts:204:15)
at createButtonShape (RectangularButton.ts:175:33)
at callback (Multilink.ts:111:10)
at listener (TinyEmitter.ts:95:8)
at emit (ReadOnlyProperty.ts:303:22)
at _notifyListeners (ReadOnlyProperty.ts:254:13)
at unguardedSet (ReadOnlyProperty.ts:238:11)
at set (DerivedProperty.ts:155:12)
id: Bayes Puppeteer
Snapshot from 8/26/2022, 3:59:33 AM
samreid commented 1 year ago

This was introduced by the new layout changes. The content of the button for ?stringTest=xss is only 6.7 but the corner radii are 4, so it is not able to curve the button as requested. Turning off the button curvature leads to a similar problem in the gradient.

After fixing those, there is still a layout problem like so:

image

Still, I'll commit this workaround until we can get to the root of the problem.

Also, the english case doesn't look much like a button, so this would be good to solve in a better way:

image