search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Use UndoIcon in this sim. #234

Open pixelzoom opened 2 years ago

pixelzoom commented 2 years ago

In https://github.com/phetsims/calculus-grapher/issues/78, we standardized and generalized UndoButton, and factored out UndoIcon. UndoIcon is implemented as a very specific Shape. The button looks like this

screenshot_1938

build-a-molecule has RefillButton, which looks like this:

image

RefillButton uses fontawesome 'reply-solid', which is close to UndoIcon, but not identical.

Consider using UndoIcon in this sim.

arouinfar commented 2 years ago

Thanks @pixelzoom, good to know there is now support for the UndoIcon.

I don't have a preference for one iconic arrow over the other. The refill button behaves differently than the undo button, so I don't think we necessarily need to use UndoIcon here. However, I'll defer to the responsible dev @jonathanolson to decide if there's an implementation benefit to making the switch.

This doesn't have a significant impact on UX, so no need to publish any changes as a maintenance release.