search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

Published sim can get locked up #242

Closed jbphet closed 1 year ago

jbphet commented 1 year ago

As of this writing the published version of build-a-molecule is 1.0.15. I tried the short sequence of steps to reproduce an issue that was found on CT on this version of the sim, and found that it locks the sim up entirely. Not good. If the console is open the "Bond not found" message is printed there.

Looking in the source code, the "Bond not found" message is actually a throw, not an assert, so we should fix that and should potentially deploy the other fixes related to the CT issue.

@jonathanolson and I discussed this and thought we should bundle it with https://github.com/phetsims/fractions-common/issues/120 and do either a general fix or a set of sim-specific maintenance releases during the next iteration.

jbphet commented 1 year ago

@jonathanolson and I have implemented a more general fix and removed the more workaround-ish fix from the main branch for build-a-molecule. This greatly reduced the CT errors versus what was occurring before we started addressing these problems, but it doesn't clear them up 100%. Because of that, and because it will be easier to deploy the workarounds for the maintenance release (no common code changes), I've decided to go that route.

jbphet commented 1 year ago

This has been fixed in version 1.0.16, which is live on the website as of this writing. Closing.