search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

CT Cannot read property stepEmitter of undefined #94

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago 
build-a-molecule : fuzz : built : run
Query: fuzz&memoryLimit=1000
Uncaught TypeError: Cannot read property 'stepEmitter' of undefined
TypeError: Cannot read property 'stepEmitter' of undefined
    at new C (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:6822923)
    at Object.fire (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:6830682)
    at C.setButtonState (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:6763031)
    at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:6762415)
    at C.buttonUp (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:6761602)
    at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:6760583)
    at H.value (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:718860)
    at H.value (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:718552)
    at H.value (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:717076)
    at H.touchEndAction.e.phetioPlayback (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/build/phet/build-a-molecule_en_phet.html?postMessageOnLoad&postMessageOnError&postMessageOnBeforeUnload&fuzz&memoryLimit=1000:1041:706373)
id: Bayes Chrome
Approximately 5/23/2019, 3:41:49 AM
build-a-molecule : fuzz : require.js : run
Query: brand=phet&ea&fuzz&memoryLimit=1000
Uncaught TypeError: Cannot read property 'stepEmitter' of undefined
TypeError: Cannot read property 'stepEmitter' of undefined
    at new Molecule3DDialog (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/js/view/view3d/Molecule3DDialog.js?bust=1558614188113:190:43)
    at Object.fire (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/js/view/view3d/ShowMolecule3DButtonNode.js?bust=1558614188113:38:24)
    at ButtonListener.setButtonState (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/ButtonListener.js?bust=1558614188113:110:31)
    at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/ButtonListener.js?bust=1558614188113:74:14)
    at ButtonListener.buttonUp (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/DownUpListener.js?bust=1558614188113:134:22)
    at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/DownUpListener.js?bust=1558614188113:63:16)
    at Input.dispatchToListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558614188113:1750:27)
    at Input.dispatchEvent (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558614188113:1706:12)
    at Input.upEvent (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558614188113:1467:12)
    at Input.mouseUpAction.Action.phetioPlayback (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558614188113:247:14)
id: Bayes Chrome
Approximately 5/23/2019, 3:41:49 AM
build-a-molecule : fuzz : require.js : run
Query: brand=phet&ea&fuzz&memoryLimit=1000
Uncaught TypeError: Cannot read property 'stepEmitter' of undefined
TypeError: Cannot read property 'stepEmitter' of undefined
    at new Molecule3DDialog (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/js/view/view3d/Molecule3DDialog.js?bust=1558621349515:190:43)
    at Object.fire (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/js/view/view3d/ShowMolecule3DButtonNode.js?bust=1558621349515:38:24)
    at ButtonListener.setButtonState (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/ButtonListener.js?bust=1558621349515:110:31)
    at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/ButtonListener.js?bust=1558621349515:74:14)
    at ButtonListener.buttonUp (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/DownUpListener.js?bust=1558621349515:134:22)
    at Object.cancel (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/DownUpListener.js?bust=1558621349515:75:14)
    at Input.dispatchToListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558621349515:1750:27)
    at Input.dispatchEvent (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558621349515:1706:12)
    at Input.cancelEvent (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558621349515:1566:12)
    at Input.touchCancelAction.Action.phetioPlayback (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558621349515:417:16)
id: Bayes Chrome
Approximately 5/23/2019, 3:41:49 AM
build-a-molecule : fuzz : require.js-canvas : run
Query: brand=phet&ea&fuzz&rootRenderer=canvas&memoryLimit=1000
Uncaught TypeError: Cannot read property 'stepEmitter' of undefined
TypeError: Cannot read property 'stepEmitter' of undefined
    at new Molecule3DDialog (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/js/view/view3d/Molecule3DDialog.js?bust=1558609459453:190:43)
    at Object.fire (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/js/view/view3d/ShowMolecule3DButtonNode.js?bust=1558609459453:38:24)
    at ButtonListener.setButtonState (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/ButtonListener.js?bust=1558609459453:110:31)
    at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/ButtonListener.js?bust=1558609459453:74:14)
    at ButtonListener.buttonUp (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/DownUpListener.js?bust=1558609459453:134:22)
    at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/DownUpListener.js?bust=1558609459453:63:16)
    at Input.dispatchToListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558609459453:1750:27)
    at Input.dispatchEvent (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558609459453:1706:12)
    at Input.upEvent (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558609459453:1467:12)
    at Input.touchEndAction.Action.phetioPlayback (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558609459453:375:16)
id: Bayes Chrome
Approximately 5/23/2019, 3:41:49 AM
build-a-molecule : xss-fuzz : run
Query: brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Uncaught TypeError: Cannot read property 'stepEmitter' of undefined
TypeError: Cannot read property 'stepEmitter' of undefined
    at new Molecule3DDialog (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/js/view/view3d/Molecule3DDialog.js?bust=1558615510474:190:43)
    at Object.fire (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/build-a-molecule/js/view/view3d/ShowMolecule3DButtonNode.js?bust=1558615510474:38:24)
    at ButtonListener.setButtonState (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/ButtonListener.js?bust=1558615510474:110:31)
    at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/ButtonListener.js?bust=1558615510474:74:14)
    at ButtonListener.buttonUp (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/DownUpListener.js?bust=1558615510474:134:22)
    at Object.up (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/DownUpListener.js?bust=1558615510474:63:16)
    at Input.dispatchToListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558615510474:1750:27)
    at Input.dispatchEvent (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558615510474:1706:12)
    at Input.upEvent (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558615510474:1467:12)
    at Input.touchEndAction.Action.phetioPlayback (https://bayes.colorado.edu/continuous-testing/snapshot-1558604509519/scenery/js/input/Input.js?bust=1558615510474:375:16)
id: Bayes Chrome
Approximately 5/23/2019, 3:41:49 AM
Denz1994 commented 5 years ago

Self-assigning, I think this was due to a recent refactor I made to use Emitter.

Denz1994 commented 5 years ago

This commit cae3b19a36d4b3ab6129a8434532b39d57f578fb might have fixed the issue.

Additionally, I made a change to use Array.shift() instead of Array.remove.

Both were breaking CT so I'll address them here. Awaiting a few CT cycles before closing.

Denz1994 commented 5 years ago

CT is looking clear and I can't reproduce locally. Closing.