search

phetsims / build-a-molecule

"Build a Molecule" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 7 forks source link

CT various in ElementHistogram, BAMView, and KitView #96

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago 
build-a-molecule : build : phet
Failure to grunt snapshot-1559918867872/build-a-molecule:
Running "lint-all" task

/data/share/phet/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/ElementHistogram.js
  25:9   error  Return statement should not contain assignment      no-return-assign
  25:16  error  'thihs' is not defined                              no-undef
  56:13  error  'element' is never reassigned. Use 'const' instead  prefer-const
  82:15  error  'element' is never reassigned. Use 'const' instead  prefer-const

/data/share/phet/continuous-testing/snapshot-1559918867872/build-a-molecule/js/view/BAMView.js
  13:7  error  'BAMConstants' is assigned a value but never used  no-unused-vars
  17:7  error  'Rectangle' is assigned a value but never used     no-unused-vars

/data/share/phet/continuous-testing/snapshot-1559918867872/build-a-molecule/js/view/KitView.js
  92:19  error  Unexpected trailing comma  comma-dangle

✖ 7 problems (7 errors, 0 warnings)
  3 errors and 0 warnings potentially fixable with the `--fix` option.
Fatal error: 7 Lint Errors

Approximately 6/7/2019, 8:47:47 AM
build-a-molecule : xss-fuzz : load
Query: brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Uncaught ReferenceError: thihs is not defined
ReferenceError: thihs is not defined
    at https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/ElementHistogram.js?bust=1559922563089:25:9
    at Array.map (<anonymous>)
    at new ElementHistogram (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/ElementHistogram.js?bust=1559922563089:24:39)
    at MoleculeStructure.getHistogram (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeStructure.js?bust=1559922563089:259:14)
    at MoleculeList.addAllowedStructure (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:139:50)
    at Array.forEach (<anonymous>)
    at MoleculeList.loadMasterData (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:69:22)
    at Function.MoleculeList.startInitialization (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:158:20)
    at Function.MoleculeList.getMasterInstance (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:166:20)
    at https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:274:16
id: Bayes Chrome
Approximately 6/7/2019, 8:47:47 AM
build-a-molecule : xss-fuzz : run
Query: brand=phet&ea&fuzz&stringTest=xss&memoryLimit=1000
Uncaught ReferenceError: thihs is not defined
ReferenceError: thihs is not defined
    at https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/ElementHistogram.js?bust=1559922563089:25:9
    at Array.map (<anonymous>)
    at new ElementHistogram (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/ElementHistogram.js?bust=1559922563089:24:39)
    at MoleculeStructure.getHistogram (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeStructure.js?bust=1559922563089:259:14)
    at MoleculeList.addAllowedStructure (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:139:50)
    at Array.forEach (<anonymous>)
    at MoleculeList.loadMasterData (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:69:22)
    at Function.MoleculeList.startInitialization (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:158:20)
    at Function.MoleculeList.getMasterInstance (https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:166:20)
    at https://bayes.colorado.edu/continuous-testing/snapshot-1559918867872/build-a-molecule/js/model/MoleculeList.js?bust=1559922563089:274:16
id: Bayes Chrome
Approximately 6/7/2019, 8:47:47 AM
Denz1994 commented 5 years ago

The above commit should have fixed linting errors. The this reference was also corrected in a previous commit. Will let CT run a few cycles before closing.