search

phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Review pointer areas #121

Closed Luisav1 closed 1 year ago

Luisav1 commented 1 year ago

From self code review: https://github.com/phetsims/build-a-nucleus/issues/112.

Are pointer areas optimized, especially for touch? (run with query parameter showPointerAreas) Do pointer areas overlap? (run with query parameter showPointerAreas) Overlap may be OK in some cases, depending on the z-ordering (if the front-most object is supposed to occlude pointer areas) and whether objects can be moved.

Luisav1 commented 1 year ago

This is what it looks like after increasing touch pointer areas. @ariel-phet could you please review and let us know what you think? Thanks! image

Luisav1 commented 1 year ago

We talked about it on slack and things are looking really good. @ariel-phet feel free to do a quick confirmation and then close.

Michael Kauzmann
:spiral_calendar_pad:  [23 hours ago](https://phetsims.slack.com/archives/C6HPE0J91/p1692037296273659)
Do we have a philosophy about trying to keep mouse and touch areas the same? Right now we are pretty much only expanding the touch areas, and I'm unsure if it matters. Does anyone recommend bringing the mouse areas (blue) up to match the touch areas?
image.png

image.png

6 replies

Chris Malley
  [23 hours ago](https://phetsims.slack.com/archives/C6HPE0J91/p1692037417230219?thread_ts=1692037296.273659&cid=C6HPE0J91)
I don’t recommend making them the same as a convention. They are different pointers, with different usability concerns.  (edited) 

Marla Schulz
  [23 hours ago](https://phetsims.slack.com/archives/C6HPE0J91/p1692037645987739?thread_ts=1692037296.273659&cid=C6HPE0J91)
If it’s helpful, in MSaB I remember only really expanding touch area not mouse area. And they definitely didn’t match all the time.

Kathryn Woessner
:pizza:  [23 hours ago](https://phetsims.slack.com/archives/C6HPE0J91/p1692037716107949?thread_ts=1692037296.273659&cid=C6HPE0J91)
The touch area expansion is to help with touch on small screens, such as a phone, if I recall correctly.

Sam Reid
  [23 hours ago](https://phetsims.slack.com/archives/C6HPE0J91/p1692037950798609?thread_ts=1692037296.273659&cid=C6HPE0J91)
Mouse bounds should generally be fitted to the button in my opinion

Michael Kauzmann
:spiral_calendar_pad:  [23 hours ago](https://phetsims.slack.com/archives/C6HPE0J91/p1692038008123239?thread_ts=1692037296.273659&cid=C6HPE0J91)
Thanks all, sounds like the above image is correct and in line with PhET's previous work.
:+1:
1

Kathy Perkins
  [21 hours ago](https://phetsims.slack.com/archives/C6HPE0J91/p1692042459570569?thread_ts=1692037296.273659&cid=C6HPE0J91)
Yep - touch area generally bigger so its easier to touch and snag.
Luisav1 commented 1 year ago

Meeting with @ariel-phet, we can confirm the touch areas are looking good. Closing.