phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

BANConstants has many positioning and size constants that can be derived #135

Closed Luisav1 closed 1 year ago

Luisav1 commented 1 year ago

From #112.

For an example, follow BAMConstants.

  // center of the atom in view coordinates
  SCREEN_VIEW_ATOM_CENTER_X: 335,
  SCREEN_VIEW_ATOM_CENTER_Y: 339,

  // the x distance between the left side of the nucleon energy levels
  X_DISTANCE_BETWEEN_ENERGY_LEVELS: 255,
zepumph commented 1 year ago

I couldn't find any others. Will you spot check and let me know if any others should be changed?

Also, I found that in the constants file an alpha value was being set to 200. I changed it to 1 (the max). Please update to .8 if you meant for it to be 200/255.

Luisav1 commented 1 year ago

I compared it with the published version and it seems the max values should be used. I didn't find any other values that should be changed either. Thanks @zepumph, closing this issue now.