phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

removeParticle from BANScreenView can be move to BANModel and renamed #138

Closed Luisav1 closed 1 year ago

Luisav1 commented 1 year ago

From #112. removeParticle in BANScreenView only removes the particle from the model particle arrays so it can be move to BANModel.

BANModel already has a removeParticle function that removes particle's from the particles array. So a rename and maybe an investigation into why there are so many removeParticle functions would be good to do.

zepumph commented 1 year ago

@Luisav1 and I simplified the removeParticle() logic so now there is just a function on the model, and ParticleAtom (plus some overrides). We like this better than having things in the screen view. Closing