search

phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

DecayEquationModel only needs the cellModellArray[ protonNumber ] row instead of the whole cellModelArray #154

Closed Luisav1 closed 1 year ago

Luisav1 commented 1 year ago

From #112.

zepumph commented 1 year ago

I'm not sure that is true, because we link to updates whenever the protonNumber changes. Should we just keep things as is?

https://github.com/phetsims/build-a-nucleus/blob/475e3eebcb4a365cff2880cf8318f45f1b5d8f36/js/chart-intro/model/DecayEquationModel.ts#L39-L40

Luisav1 commented 1 year ago

Yes that makes sense. Things should be kept as is. Thanks @zepumph. Closing.