search

phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Rename *BooleanProperty -> *Property #166

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

Like for doesNuclideExistBooleanProperty, it is redundant to call it a Boolean Property. The name should signify that with "does"

nuclideExistsProperty could also be a simpler name.

Tagging @jbphet since he is currently working on the code review. We hit this while cleaning up over in https://github.com/phetsims/build-a-nucleus/issues/164

zepumph commented 1 year ago

I renamed:

isStableBooleanProperty showMagicNumbersBooleanProperty arrowXPositionNumberProperty doesNuclideExistBooleanProperty halfLifeArrowRotationNumberProperty

Closing