search

phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Consider adding labels to the full nucleus stability chart #168

Closed jbphet closed 1 year ago

jbphet commented 1 year ago

There is a button in the "Chart Intro" screen that brings up a modal dialog containing a full chart of nucleus stabilities. There are no labels on the axes of this chart, which I recall being a pet peeve of one of my former teachers. When I click on the "Full Chart" link in this dialog, a web page is opened that shows an interactive version of the chart with labels on the axes. However, PhET sims are sometimes used in environments where outside internet access isn't available, so students might not be able to access the click-thru version of the chart. Thus, I think it would be good to have labels on the chart that is available within the sim.

Full chart from sim:

image

Full chart from external link available in the sim:

image

This came up during code review, see https://github.com/phetsims/build-a-nucleus/issues/165.

zepumph commented 1 year ago

I like the idea! Let's see what @Luisav1 thinks.

zepumph commented 1 year ago

In addition to this work, @Luisav1 was talking to Jason and they may be changing the colors in the full chart app anyways. Let's wait for that to happen before taking a new screenshot. Don't forget to update the notes of the license over in https://github.com/phetsims/build-a-nucleus/issues/180 with what it takes to get the new screenshot (more details is better!).

zepumph commented 1 year ago

@Luisav1, what is the current status of this issue?

Luisav1 commented 1 year ago

The screenshot still has a little black stroke on the right that needs to be removed. image Update the screenshot and then close.

Luisav1 commented 1 year ago

The screenshot now shows the full nuclide chart with matching colors to the sim and axis labels as well. Closing.