phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Clean up violations of the 120 column width recommendation #176

Closed jbphet closed 1 year ago

jbphet commented 1 year ago

Our coding-conventions.md document says, "Generally, lines should not exceed 120 columns. Break up long statements, expressions...". I'm running into a lot of violations of this recommendation, and it makes it tricky for people like me with older eyes who have to use larger fonts. I'd recommend making a pass through the code and cleaning this up a bit. Some violations are reasonable, but I've seen quite a few already in the handful of files that I've looked at.

Here is an example:

image

image

zepumph commented 1 year ago

@Luisav1 can you please take the lead on this?

Luisav1 commented 1 year ago

Thanks @jbphet! This was all fixed in the commits above. Closing.