search

phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Can we retain any sort of asset file for the `fullNuclideChart.png` image? #180

Closed jbphet closed 1 year ago

jbphet commented 1 year ago

From code review, see #165.

There is an item in the code review checklist that says, "Is there a file in assets/ for every resource file in sound/ and images/?" There isn't such an asset file for fullNuclideChart.png, but this may well be a case where it isn't possible to have one. @Luisav1 - The license file entry for this image says, "unmodified screenshot of project created by Luisa Vargas". Is there any other sort of asset that we should retain if we ever wanted to, so, produce a higher-res version of this image? If not, can you enhance the note to say how it could be recreated if necessary?

zepumph commented 1 year ago

While looking over this, I made a small refactor with the full chart push button. I also updated the notes. I'm not sure how the background became white, for reproducibility, it may be nice to note that @Luisav1. Can you finish this one off?

zepumph commented 1 year ago

On hold until https://github.com/phetsims/build-a-nucleus/issues/168 is ready.

Luisav1 commented 1 year ago

Talking with @zepumph, taking this off-hold since we only need to update the license to match necessary steps to have the current screenshot (even though the link's chart colors would eventually match).

Luisav1 commented 1 year ago

Updated license.json to include details to get current screenshot. Closing.