search

phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Symbol Node and Available Decays panel bounds not updating properly #187

Closed Luisav1 closed 1 year ago

Luisav1 commented 1 year ago

While working on https://github.com/phetsims/build-a-nucleus/issues/178, @zepumph and I found that the bounds of the Available Decays panel and of the Symbol node weirdly change when the locale changes dynamically.

For example, this is when the sim is loaded with strings=long. The symbol node pushes its bounds to the left, making the margin between nodes a bit small. image

And when the locale is dynamically changed, the panels are no longer right-aligned and the Symbol node pushes its bounds to the right. image

@ariel-phet Is this something we wanted to work on to fix?

ariel-phet commented 1 year ago

@Luisav1 @zepumph my suggestion would be to not worry about this issue and mark it deferred. It is pretty minor, and in no way should block publication as it seems like it might take a fair bit of effort to fix.

However, I would leave it as an open issue, that could potentially be tackled or rechecked at some point in the future.

zepumph commented 1 year ago

If your thoughts are that someone should do it at some point, then I'll definitely just go in now and just change the couple of maxWidths to even this out, especially while the code is fresh. It won't take long. No need to have such a small thing looming for years

zepumph commented 1 year ago

Just needed to tweak one maxWidth for the SymbolAccordionBox:

image

image