phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

slight overlap with stringTest=dynamic #192

Closed Nancy-Salpepi closed 12 months ago

Nancy-Salpepi commented 12 months ago

Test device MacBook Air M1 chip

Operating System 13.5.1

Browser Safari 16.6

Problem description For https://github.com/phetsims/qa/issues/977, with stringTest=dynamic, the Reset All button and Electron Cloud checkbox touch areas slightly overlap.

Visuals

Screenshot 2023-09-13 at 8 18 56 PM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: Build a NucleusBuild a Nucleus URL: https://phet-dev.colorado.edu/html/build-a-nucleus/1.0.0-dev.23/phet/build-a-nucleus_all_phet.html?stringTest=dynamic&showPointerAreas Version: 1.0.0-dev.23 2023-09-12 15:57:17 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Safari/605.1.15 Language: en-US Window: 1317x706 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
zepumph commented 12 months ago

@Luisav1 will take the lead making the the text maxWidth a bit smaller. We want a small margin between the two.

Luisav1 commented 12 months ago

Thanks @Nancy-Salpepi! This was fixed in the commit above. Closing.