phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Fuzz errors with parameters #212

Closed KatieWoe closed 10 months ago

KatieWoe commented 11 months ago

Test device Samsung Operating System Win 11 Browser Chrome Problem description For https://github.com/phetsims/qa/issues/994. Found while testing https://github.com/phetsims/build-a-nucleus/issues/202. I ran a fuzz test on the debug version with chartIntroScreenNeutrons and chartIntroScreenProtons and got these errors, though it didn't freeze the sim.

Visuals fuzzerror

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Build a Nucleus‬ URL: https://phet-dev.colorado.edu/html/build-a-nucleus/1.1.0-rc.2/phet/build-a-nucleus_all_phet.html Version: 1.1.0-rc.2 2023-10-12 21:48:01 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36 Language: en-US Window: 1536x707 Pixel Ratio: 1.25/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
Luisav1 commented 10 months ago

Fuzzing locally with the same query query parameters (http://localhost:8080/build-a-nucleus/build-a-nucleus_en.html?brand=phet&ea&debugger&chartIntroScreenProtons=2&chartIntroScreenNeutrons=2&fuzz) I get these two other assertion errors quite quickly: image image

zepumph commented 10 months ago

The problems here were caused by https://github.com/phetsims/build-a-nucleus/issues/202. I recommend closing this issue as a duplicate. "Cannot fire while already firing" is a classic example of a downstream assertion. The very first assertion in @KatieWoe's console is most likely "should not be called if disposed". Let's pick this up over in https://github.com/phetsims/build-a-nucleus/issues/202