phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Overlap seen with stringTests #27

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System macOS 12.4

Browser safari

Problem description For https://github.com/phetsims/qa/issues/809 I see overlap of text and text/panels when using stringTest=double, long and RTL.

Visuals

Screen Shot 2022-06-08 at 12 34 56 PM Screen Shot 2022-06-08 at 12 35 29 PM Screen Shot 2022-06-08 at 12 36 46 PM Screen Shot 2022-06-08 at 12 38 22 PM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Build a Nucleus‬ URL: https://phet-dev.colorado.edu/html/build-a-nucleus/1.0.0-betaDecay.11/phet/build-a-nucleus_all_phet.html Version: 1.0.0-betaDecay.11 2022-06-04 01:06:50 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.61 Safari/537.36 Language: en-US Window: 1365x694 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
Luisav1 commented 2 years ago

Thanks @Nancy-Salpepi! This should be fixed in the commits above. You can check it and close it if it's fixed.

Nancy-Salpepi commented 2 years ago

Hi @Luisav1! Things are looking much better, but I'm still seeing overlap in the particle count panel with stringTest=double and stringTest=long.

Screen Shot 2022-06-21 at 1 14 26 PM Screen Shot 2022-06-21 at 1 15 24 PM
Luisav1 commented 2 years ago

I missed that, thanks @Nancy-Salpepi! It should be fixed now.

Nancy-Salpepi commented 2 years ago

Looks good @Luisav1! Closing.