Closed Luisav1 closed 1 year ago
I brought this to dev meeting today, and there weren't many concerns about dropping the code into the third screen (we've worked with Three.js code in Molecule Shapes), there were bigger concerns about creating external dependencies through links, as well as compatibility with the PhET ecosystem in general ( accessibility, dynamic languages, PhET-iO), as well as how we would handle any bugs that may come up through QA testing.
Here is the conversation:
Overall the consensus was that if we want to embed it it's very possible, but there's a lot of questions that come up with that decision. The possibility of porting was also discussed, however the recommendation was to only port 2D functionality. Porting the 3D functionality would probably be too big of a lift for this.
I'm going to un-assign @jonathanolson for now, since there were a lot of answers and questions that came up from dev meeting that should be discussed with @ariel-phet and @Luisav1 first, before bringing in JO.
I just wanted to experiment lightly with what it would look like to use an iframe to "host" the third screen without building it with our code. My guess is that we could detect offline and swap things out for a "go to this link for a cool app" sort of message.
It is rough, but it was working without the fullscreen style. Not sure if we should pursue it more.
From design meeting today, from a partnership/licensing reasons, we don't want to load the link in an iframe. Instead we should include the link in an info dialog on screen 2.
?allowLinks
query parameter. (just text not a link)@Luisav1 can you please work on the screenshot portion of this. I think either of us could work on the dialog/button portion.
From design meeting 7/21 we decided to place the button beside the 'Magic Numbers' checkbox to the right of it or below it, if there's space.
@Luisav1 to confirm the image license, @zepumph to review the code, and us to confirm that we like it in next design meeting.
Questions from the review:
phet.colorado.edu/links/full-nuclide-chart
. Right now it is hard coded to https://energyeducation.ca/simulations/nuclear/nuclidechart.html in the sim directly.~FullChartDialog
. The ChartIntroScreenView is >400 lines, so I feel like any way to pull modularity out of a file that size is a win.
- Add a dialog titled, "Full Nuclide Chart"
@Luisav1 and I talked yesterday and she came up with:
i
info button to open the dialog. Let's make a button called "Full Chart", styled like the tweaker buttons for adding nuclides.
The BaN simulation builds up on the concept of nuclides and the decay they undergo throughout screen 1 and 2. Screen 2 is where the Chart of the Nuclides is introduced and the goal is to eventually show a complete version of the Chart of the Nuclides on Screen 3. A version of this chart already exists here. My supervisor Jason and another student built this chart using the Three.js library.
We wanted to see what our options are on creating this third screen on BaN or if it is even possible. So far we thought of the following options:
Licensing is not an issue here since we are closely working with Jason and we'd like to see BaN show the complete chart, through these options or any other options too.
@jonathanolson When you have some time, your input here would be nice on how feasible some of this options are or if you have any other ideas on having a screen that features the complete chart. Thanks!