search

phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Nested options for bounding box in SymbolNode #86

Closed Luisav1 closed 1 year ago

Luisav1 commented 1 year ago

Currently the options for SymbolNode are a bit messy since they include the options for BoundingBox too. It'd be nice to separate the BoundingBox options in a nested options block.

{
      chargeProperty: null,
      fill: 'white',
      symbolTextFill: 'black',
      protonCountDisplayFill: PhetColorScheme.RED_COLORBLIND,
      massNumberDisplayFill: 'black',
      boundingBoxStroke: 'black',
      tandem: Tandem.REQUIRED // TODO: How to support phet-brand and sub-instrumented components? This applies to all the commented out tandems
    }
zepumph commented 1 year ago

This is blocked by https://github.com/phetsims/shred/issues/32. Updating assignment and labels.

zepumph commented 1 year ago

Over in https://github.com/phetsims/build-a-nucleus/issues/80 we went a different direction instead of trying to use a SymbolNode for a new view case, so this is no longer needed. Closing